Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1418)

Issue 219780044: Replace most uses of scm_{from,to}_locale_* with fixed encodings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by dak
Modified:
4 years, 5 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace most uses of scm_{from,to}_locale_* with fixed encodings Most are either identifiable as utf8, or as byte stream (more or less called latin1) or pure ASCII. Since conversion to C++ strings is factored through separate (and too few) functions, those accesses are not yet reordered in a satisfactory manner.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -46 lines) Patch
M lily/dynamic-performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/font-config-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/general-scheme.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M lily/grob-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/grob-property.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/guile-init.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lily-guile-macros.hh View 3 chunks +21 lines, -2 lines 0 comments Download
M lily/lexer.ll View 3 chunks +4 lines, -4 lines 0 comments Download
M lily/lily-guile.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-lexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/lyric-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/open-type-font.cc View 2 chunks +5 lines, -1 line 0 comments Download
M lily/open-type-font-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/pango-font.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 3 chunks +9 lines, -9 lines 0 comments Download
M lily/pfb-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/piano-pedal-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/source-file.cc View 1 chunk +4 lines, -1 line 0 comments Download
M lily/translator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/ttf.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tweak-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
lemzwerg
4 years, 8 months ago (2015-03-15 19:38:18 UTC) #1
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b