Issue 219550043: Removed http_method specification.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 219550043: Removed http_method specification. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by cmassaro

Modified:
7 years, 7 months ago

Reviewers:
vadimsh, cmassaro1, M-A

CC:
swarming-eng_googlegroups.com, pgervais

Base URL:
https://code.google.com/p/swarming@master

Visibility:
Public.

More Reviews

Description

Removed http_method specification. R=maruel@chromium.org, vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=df374edb8c5173a7fb04f9a410ef1894f36e9fb1

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	appengine/swarming/handlers_endpoints.py	View		4 chunks	+4 lines, -9 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

M-A

lgtm https://codereview.appspot.com/219550043/diff/1/appengine/swarming/handlers_endpoints.py File appengine/swarming/handlers_endpoints.py (left): https://codereview.appspot.com/219550043/diff/1/appengine/swarming/handlers_endpoints.py#oldcode193 appengine/swarming/handlers_endpoints.py:193: swarming_rpcs.BotId, swarming_rpcs.BotInfo, http_method='GET') That's interesting, what about protobuf ...

9 years, 4 months ago (2015-03-31 20:48:19 UTC) #2

cmassaro

Committed patchset #1 (id:1) manually as df374edb8c5173a7fb04f9a410ef1894f36e9fb1 (presubmit successful).

9 years, 4 months ago (2015-03-31 21:25:51 UTC) #3

cmassaro

https://codereview.appspot.com/219550043/diff/1/appengine/swarming/handlers_endpoints.py File appengine/swarming/handlers_endpoints.py (left): https://codereview.appspot.com/219550043/diff/1/appengine/swarming/handlers_endpoints.py#oldcode193 appengine/swarming/handlers_endpoints.py:193: swarming_rpcs.BotId, swarming_rpcs.BotInfo, http_method='GET') On 2015/03/31 20:48:19, M-A wrote: > ...

9 years, 4 months ago (2015-03-31 21:26:14 UTC) #4

cmassaro1

9 years, 4 months ago (2015-03-31 21:26:37 UTC) #5

Heads up: restarting the server.

On Tue, Mar 31, 2015 at 2:25 PM, <cmassaro@chromium.org> wrote:

> Committed patchset #1 (id:1) manually as
> df374edb8c5173a7fb04f9a410ef1894f36e9fb1 (presubmit successful).
>
> https://codereview.appspot.com/219550043/
>

Expand All Messages | Collapse All Messages