Issue 219520043: ibus-ui-gtk3: Draw gray color on PropertyPanel handle

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 219520043: ibus-ui-gtk3: Draw gray color on PropertyPanel handle (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 1 month ago by fujiwara

Modified:
9 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ibus-ui-gtk3: Draw gray color on PropertyPanel handle Users can move the position of IBus PropertyPanel with the mouse but currently it is too hard to find the handle on the panel. Now the handle is drawn by the gray color for the visibility. TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #3. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	ui/gtk3/handle.vala	View	1	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/219520043/diff/1/ui/gtk3/handle.vala File ui/gtk3/handle.vala (right): https://codereview.appspot.com/219520043/diff/1/ui/gtk3/handle.vala#newcode39 ui/gtk3/handle.vala:39: Please add a comment for below code.

9 years, 1 month ago (2015-03-31 15:11:10 UTC) #3

fujiwara

9 years, 1 month ago (2015-04-01 02:41:39 UTC) #4

https://codereview.appspot.com/219520043/diff/1/ui/gtk3/handle.vala
File ui/gtk3/handle.vala (right):

https://codereview.appspot.com/219520043/diff/1/ui/gtk3/handle.vala#newcode39
ui/gtk3/handle.vala:39: 
On 2015/03/31 15:11:10, Peng wrote:
> Please add a comment for below code.

Done.

Expand All Messages | Collapse All Messages