Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 2192047: Don't try to show products quantities for a location if there are no moves. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by bch
Modified:
15 years, 1 month ago
Reviewers:
ced, yangoon1
Visibility:
Public.

Description

Avoid to open all the products when the user double-clic on a location (of the stock locations tree). This is much faster when there is a lot of product in the DB.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed domain on action + dict/list comprehension #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M location.xml View 1 chunk +0 lines, -1 line 1 comment Download
M product.py View 1 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7
bch
15 years, 4 months ago (2010-09-21 08:56:32 UTC) #1
yangoon1
It seems a little bit arbitrary to me to do just skip_zero=False, while you do ...
15 years, 4 months ago (2010-09-21 10:04:26 UTC) #2
bch
On 2010/09/21 10:04:26, yangoon wrote: > It seems a little bit arbitrary to me to ...
15 years, 4 months ago (2010-09-21 10:43:20 UTC) #3
yangoon1
On 2010/09/21 10:43:20, bch wrote: > On 2010/09/21 10:04:26, yangoon wrote: > Yes good idea, ...
15 years, 4 months ago (2010-09-21 10:59:17 UTC) #4
bch
Just a note about this new version: removing the domain on the action decreased the ...
15 years, 4 months ago (2010-09-23 13:04:56 UTC) #5
ced
http://codereview.appspot.com/2192047/diff/7001/location.xml File location.xml (left): http://codereview.appspot.com/2192047/diff/7001/location.xml#oldcode91 location.xml:91: <field name="domain">['OR', ('quantity', '!=', 0.0), ('forecast_quantity', '!=', 0.0)]</field> This ...
15 years, 4 months ago (2010-09-23 13:08:59 UTC) #6
ced
15 years, 2 months ago (2010-12-04 16:20:42 UTC) #7
I think we can close this patch because we will go in an other direction to fix
this.
http://code.google.com/p/tryton/wiki/Release_2_0_0#stock
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b