Don't try to show products quantities for a location if there are no moves.

Avoid to open all the products when the user double-clic on a location (of the stock locations tree). This is much faster when there is a lot of product in the DB.

[yangoon1, 2010-09-21 10:04:26]

It seems a little bit arbitrary to me to do just skip_zero=False, while you do
with_childs=True.

To be clear for the user I would prefer to see those options on class
ChooseStockDateInit and to set those default there. So it is up to the user,
what he wants and he is informed about what he gets.

http://codereview.appspot.com/2192047/diff/1/product.py
File product.py (right):

http://codereview.appspot.com/2192047/diff/1/product.py#newcode159
product.py:159: :param skip_zero: a boolean to list also items with zero
quantity
a boolean to not list items with zero quantity

[bch, 2010-09-21 10:43:20]

On 2010/09/21 10:04:26, yangoon wrote:
> It seems a little bit arbitrary to me to do just skip_zero=False, while you do
> with_childs=True.

Yes, I was focusing on performance but I just realized that this modification
does not solve the problem. So I will re-put skip_zero to False and try to find
other (real) improvements.


> To be clear for the user I would prefer to see those options on class
> ChooseStockDateInit and to set those default there. So it is up to the user,
> what he wants and he is informed about what he gets.

Yes good idea, if it's important for you, maybe add a feature request on the
tracker as I want to dedicate this issue to raw speed improvement.


> http://codereview.appspot.com/2192047/diff/1/product.py
> File product.py (right):
> 
> http://codereview.appspot.com/2192047/diff/1/product.py#newcode159
> product.py:159: :param skip_zero: a boolean to list also items with zero
> quantity
> a boolean to not list items with zero quantity

[yangoon1, 2010-09-21 10:59:17]

On 2010/09/21 10:43:20, bch wrote:
> On 2010/09/21 10:04:26, yangoon wrote:

> Yes good idea, if it's important for you, maybe add a feature request on the
> tracker as I want to dedicate this issue to raw speed improvement.

Done with https://bugs.tryton.org/roundup/issue1701

[bch, 2010-09-23 13:04:56]

Just a note about this new version: removing the domain on the action decreased
the opening time of the list of product (with 100.000 product) by a factor
between 10 and 20.

[ced, 2010-09-23 13:08:59]

http://codereview.appspot.com/2192047/diff/7001/location.xml
File location.xml (left):

http://codereview.appspot.com/2192047/diff/7001/location.xml#oldcode91
location.xml:91: <field name="domain">['OR', ('quantity', '!=', 0.0),
('forecast_quantity', '!=', 0.0)]</field>
This is not a valid solution.
We must provide a way to filter on quantity in an efficient way.

[ced, 2010-12-04 16:20:42]

I think we can close this patch because we will go in an other direction to fix
this.
http://code.google.com/p/tryton/wiki/Release_2_0_0#stock