Issue 2192046: No redirect for Ajax and Options requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2192046: No redirect for Ajax and Options requests

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by fmeschbe

Modified:
15 years, 3 months ago

Reviewers:
justinedelson

Base URL:
https://svn.apache.org/repos/asf/sling/trunk/

Visibility:
Public.

Description

Proposed patch to fix: https://issues.apache.org/jira/browse/SLING-1745 https://issues.apache.org/jira/browse/SLING-1400

Patch Set 1 #

Patch Set 2 : Updated patch introducing helper methods for WebAV and Ajax detection #

Total comments: 1

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -8 lines)			Patch
		bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/HttpBasicAuthenticationHandler.java	View		1 chunk	+1 line, -1 line	0 comments	Download
		bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java	View	1	4 chunks	+183 lines, -7 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fmeschbe

Updated patch introducing helper methods for WebAV and Ajax detection

15 years, 3 months ago (2010-09-21 08:06:15 UTC) #2

justinedelson

15 years, 3 months ago (2010-09-22 15:51:05 UTC) #3

http://codereview.appspot.com/2192046/diff/4001/bundles/auth/core/src/main/ja...
File
bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
(right):

http://codereview.appspot.com/2192046/diff/4001/bundles/auth/core/src/main/ja...
bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java:1033:
|| METHOD_PROPFIND.equals(method);
this isn't quite what I meant. I was trying to suggest that we ignore the method
entirely and so this method should really be

return request.getHeader(HEADER_ACCEPTS) == null &&
(!request.getHeader(HEADER_ACCEPTS).contains("text/html"))

the reason for this is that a non-browser client should always get a 401
response and AFAIK, the Accepts header is the best way to detect if a request is
coming from a browser or not

Expand All Messages | Collapse All Messages