Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 218760043: I18N for engine longnames on ibus-setup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by fujiwara
Modified:
9 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

I18N for engine longnames on ibus-setup New API ibus_get_untranslated_language_name(). Call bindtextdomain() for each textdomains. TEST=setup

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Added i18n.init_engine() for bind_textdomain(). #

Patch Set 4 : Add bindtextdomain() for "iso_639". #

Total comments: 6

Patch Set 5 : Updated with message #4. #

Patch Set 6 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -67 lines) Patch
M setup/enginedialog.py View 1 2 3 4 6 chunks +19 lines, -22 lines 0 comments Download
M setup/enginetreeview.py View 1 2 3 4 5 chunks +11 lines, -5 lines 0 comments Download
M setup/main.py View 1 2 3 4 3 chunks +6 lines, -4 lines 0 comments Download
M src/ibusutil.h View 1 2 chunks +12 lines, -4 lines 0 comments Download
M src/ibusutil.c View 1 2 3 4 3 chunks +28 lines, -19 lines 0 comments Download
M ui/gtk2/i18n.py View 1 2 3 4 2 chunks +29 lines, -9 lines 0 comments Download
M ui/gtk2/main.py View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
fujiwara
9 years, 2 months ago (2015-03-12 10:09:44 UTC) #1
Peng
https://codereview.appspot.com/218760043/diff/1/setup/enginedialog.py File setup/enginedialog.py (right): https://codereview.appspot.com/218760043/diff/1/setup/enginedialog.py#newcode317 setup/enginedialog.py:317: self.__adjustment.set_value(self.__adjustment.get_lower()) what is it for? https://codereview.appspot.com/218760043/diff/1/ui/gtk2/i18n.py File ui/gtk2/i18n.py (right): ...
9 years, 2 months ago (2015-03-12 18:55:50 UTC) #2
fujiwara
https://codereview.appspot.com/218760043/diff/1/setup/enginedialog.py File setup/enginedialog.py (right): https://codereview.appspot.com/218760043/diff/1/setup/enginedialog.py#newcode317 setup/enginedialog.py:317: self.__adjustment.set_value(self.__adjustment.get_lower()) On 2015/03/12 18:55:49, Peng wrote: > what is ...
9 years, 2 months ago (2015-03-13 10:17:53 UTC) #3
Peng
https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c File src/ibusutil.c (right): https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c#newcode161 src/ibusutil.c:161: #endif #else return retval; #endif https://codereview.appspot.com/218760043/diff/60001/ui/gtk2/i18n.py File ui/gtk2/i18n.py (right): ...
9 years, 2 months ago (2015-03-19 14:29:01 UTC) #4
fujiwara
https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c File src/ibusutil.c (right): https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c#newcode161 src/ibusutil.c:161: #endif On 2015/03/19 14:29:00, Peng wrote: > #else > ...
9 years, 2 months ago (2015-03-24 07:34:27 UTC) #5
Peng
9 years, 2 months ago (2015-03-24 19:17:17 UTC) #6
On 2015/03/24 07:34:27, fujiwara wrote:
> https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c
> File src/ibusutil.c (right):
> 
> https://codereview.appspot.com/218760043/diff/60001/src/ibusutil.c#newcode161
> src/ibusutil.c:161: #endif
> On 2015/03/19 14:29:00, Peng wrote:
> > #else
> >     return retval;
> > #endif
> 
> Done.
> 
> https://codereview.appspot.com/218760043/diff/60001/ui/gtk2/i18n.py
> File ui/gtk2/i18n.py (right):
> 
> https://codereview.appspot.com/218760043/diff/60001/ui/gtk2/i18n.py#newcode51
> ui/gtk2/i18n.py:51: textdomain = engine.get_textdomain()
> On 2015/03/19 14:29:00, Peng wrote:
> > what about if some engines share a same textdomain? Do you think if it is
> > necessary to track which textdomain has been initialized?
> 
> I think calling bindtextdomain() many times is not a big problem.
> 
> https://codereview.appspot.com/218760043/diff/60001/ui/gtk2/i18n.py#newcode60
> ui/gtk2/i18n.py:60: gettext.bind_textdomain_codeset(textdomain, 'UTF-8')
> On 2015/03/19 14:29:00, Peng wrote:
> > those code is similar to def init():
> > 
> > How about has a function init_textdomain(domainname)?
> 
> Done.

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b