Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(398)

Issue 218160045: Reduce sys.path manipulation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by M-A
Modified:
10 years, 1 month ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming@master
Visibility:
Public.

Description

Reduce sys.path manipulation. Code still works. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=8d56c974d3e9f7f9838253424b40f21114d55321

Patch Set 1 #

Patch Set 2 : Code that actually works #

Patch Set 3 : Remove unnecessary imports #

Total comments: 2

Patch Set 4 : Fixed endpoint_handlers_api.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M appengine/auth_service/tools/run_coverage.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/components/test_support/test_env.py View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/isolate/tools/run_coverage.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/swarming/tools/run_coverage.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
M-A
Coverage for projects; Stmts Miss Cover auth_service 836 362 56.7% isolate 2251 671 70.2% swarming ...
10 years, 1 month ago (2015-03-25 01:19:20 UTC) #1
M-A
On 2015/03/25 01:19:20, M-A wrote: > Coverage for projects; > Stmts Miss Cover > auth_service ...
10 years, 1 month ago (2015-03-25 01:47:13 UTC) #2
vadimsh
https://codereview.appspot.com/218160045/diff/40001/appengine/isolate/endpoint_handlers_api.py File appengine/isolate/endpoint_handlers_api.py (right): https://codereview.appspot.com/218160045/diff/40001/appengine/isolate/endpoint_handlers_api.py#newcode21 appengine/isolate/endpoint_handlers_api.py:21: from components import auth how does it work?.. it ...
10 years, 1 month ago (2015-03-25 01:57:51 UTC) #3
M-A
https://codereview.appspot.com/218160045/diff/40001/appengine/isolate/endpoint_handlers_api.py File appengine/isolate/endpoint_handlers_api.py (right): https://codereview.appspot.com/218160045/diff/40001/appengine/isolate/endpoint_handlers_api.py#newcode21 appengine/isolate/endpoint_handlers_api.py:21: from components import auth On 2015/03/25 01:57:51, vadimsh wrote: ...
10 years, 1 month ago (2015-03-25 12:40:03 UTC) #4
vadimsh
lgtm
10 years, 1 month ago (2015-03-25 21:31:11 UTC) #5
M-A
10 years, 1 month ago (2015-03-25 21:35:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8d56c974d3e9f7f9838253424b40f21114d55321 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b