mesh module compliant to IEEE802.11-2012

mesh module compliant to IEEE802.11-2012

[hepner.christopher, 2015-03-18 07:49:48]

Dear all,

I have made some changes in order to get the 802.11s model more compliant to the
IEEE 802.11s-2012 Standard. 

The correct implementation of the protocols and proper exchange of messages is
very important for an easy comparison of the results of real measurements and
the network simulations.
The changes cover the Peer Management Protocol with the correct assignment of
categories and Actions, correct information elements and Element ID's and
HWMP-Protocol.

With the proposed changes it can be reached that the messages of the Peering
Management Protocol and Hybrid Wireless Mesh Protocol in ns-3 will be
transmitted compliant to the standard IEEE802.11-2012.
The resulting pcap files can then be analyzed by an actual version of Wireshark
without patch.
Changes in the mesh model and minor changes in the wifi model are needed.

best regards,
Christopher

[Tom Henderson, 2015-04-14 14:29:03]

Thank you for providing this patch; others have complained about this out of
date model, and lack of Wireshark compatibility, in the past:
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1901

I only had a minor comment, which is to delete some statements that have been
commented out (rather than leave the comments in the code).

I would like to make a small request, which is to help us also write at least
the scope section of the documentation of this model.  We can handle this
outside of the review of this code; I will email about it.

I suggest that Sebastien review and then we proceed to merge if no concerns
raised.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
File src/mesh/model/dot11s/peer-link-frame.cc (right):

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:45: // m_protocol = fields.protocol;
there are various statements in this file commented out rather than removed.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:110: uint32_t size =0;// 3; //Peering
protocol
why the //3 comment?

[S. Deronne, 2015-04-14 19:24:04]

Thank you for your contribution.
The wifi changes seem ok.

My main interrogation is about the commented values.
Indeed, I see some values are commented out instead of being removed in your
code.
Does this mean that there are still hesitations/discussions on some parts?

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
File src/mesh/model/dot11s/ie-dot11s-configuration.h (right):

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
src/mesh/model/dot11s/ie-dot11s-configuration.h:77: uint8_t GetUint8 () const; 
//uint16_t GetUint16 () const;
The name of this function does not provide information about its purpose.
Please also remove unused functions instead of commenting out.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
src/mesh/model/dot11s/ie-dot11s-configuration.h:85: bool Is (uint8_t cap,uint8_t
n) const;//bool Is (uint16_t cap,uint8_t n) const;
The name of this function does not provide information about its purpose.
Please also remove unused functions instead of commenting out.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
File src/mesh/model/dot11s/peer-link-frame.cc (right):

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:33: m_config (IeConfiguration ())// ,
m_reasonCode ((uint16_t)REASON11S_RESERVED)
Please remove commented code in the final version.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:176: /*{
Is there hesitations about the comment numbers?

https://codereview.appspot.com/217910043/diff/1/src/wifi/model/mgt-headers.cc
File src/wifi/model/mgt-headers.cc (right):

https://codereview.appspot.com/217910043/diff/1/src/wifi/model/mgt-headers.cc...
src/wifi/model/mgt-headers.cc:621: case PROXY_UPDATE:                   
//(bisher nicht verwendet)
Please check all your comments are in english in the last version.