Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 217910043: mesh module compliant to IEEE802.11-2012

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by hepner.christopher
Modified:
4 years, 5 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

mesh module compliant to IEEE802.11-2012

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+4793 lines, -4537 lines) Patch
M src/mesh/bindings/modulegen__gcc_ILP32.py View 2 chunks +27 lines, -9 lines 0 comments Download
M src/mesh/bindings/modulegen__gcc_LP64.py View 142 chunks +4481 lines, -4277 lines 0 comments Download
M src/mesh/model/dot11s/hwmp-protocol-mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mesh/model/dot11s/ie-dot11s-configuration.h View 3 chunks +23 lines, -30 lines 2 comments Download
M src/mesh/model/dot11s/ie-dot11s-configuration.cc View 6 chunks +25 lines, -32 lines 0 comments Download
M src/mesh/model/dot11s/ie-dot11s-peer-management.h View 1 chunk +16 lines, -17 lines 0 comments Download
M src/mesh/model/dot11s/ie-dot11s-perr.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M src/mesh/model/dot11s/peer-link-frame.cc View 11 chunks +16 lines, -15 lines 4 comments Download
M src/mesh/model/dot11s/peer-management-protocol-mac.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M src/mesh/model/mesh-information-element.h View 1 chunk +16 lines, -16 lines 0 comments Download
M src/wifi/bindings/modulegen__gcc_ILP32.py View 1 chunk +12 lines, -6 lines 0 comments Download
M src/wifi/bindings/modulegen__gcc_LP64.py View 1 chunk +12 lines, -6 lines 0 comments Download
M src/wifi/model/mgt-headers.h View 2 chunks +38 lines, -48 lines 0 comments Download
M src/wifi/model/mgt-headers.cc View 6 chunks +93 lines, -54 lines 1 comment Download

Messages

Total messages: 3
hepner.christopher
Dear all, I have made some changes in order to get the 802.11s model more ...
4 years, 6 months ago (2015-03-18 07:49:48 UTC) #1
Tom Henderson
Thank you for providing this patch; others have complained about this out of date model, ...
4 years, 5 months ago (2015-04-14 14:29:03 UTC) #2
S. Deronne
4 years, 5 months ago (2015-04-14 19:24:04 UTC) #3
Thank you for your contribution.
The wifi changes seem ok.

My main interrogation is about the commented values.
Indeed, I see some values are commented out instead of being removed in your
code.
Does this mean that there are still hesitations/discussions on some parts?

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
File src/mesh/model/dot11s/ie-dot11s-configuration.h (right):

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
src/mesh/model/dot11s/ie-dot11s-configuration.h:77: uint8_t GetUint8 () const; 
//uint16_t GetUint16 () const;
The name of this function does not provide information about its purpose.
Please also remove unused functions instead of commenting out.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/ie-dot1...
src/mesh/model/dot11s/ie-dot11s-configuration.h:85: bool Is (uint8_t cap,uint8_t
n) const;//bool Is (uint16_t cap,uint8_t n) const;
The name of this function does not provide information about its purpose.
Please also remove unused functions instead of commenting out.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
File src/mesh/model/dot11s/peer-link-frame.cc (right):

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:33: m_config (IeConfiguration ())// ,
m_reasonCode ((uint16_t)REASON11S_RESERVED)
Please remove commented code in the final version.

https://codereview.appspot.com/217910043/diff/1/src/mesh/model/dot11s/peer-li...
src/mesh/model/dot11s/peer-link-frame.cc:176: /*{
Is there hesitations about the comment numbers?

https://codereview.appspot.com/217910043/diff/1/src/wifi/model/mgt-headers.cc
File src/wifi/model/mgt-headers.cc (right):

https://codereview.appspot.com/217910043/diff/1/src/wifi/model/mgt-headers.cc...
src/wifi/model/mgt-headers.cc:621: case PROXY_UPDATE:                   
//(bisher nicht verwendet)
Please check all your comments are in english in the last version.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b