Issue 217560043: Added path to BotsService.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217560043: Added path to BotsService. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by cmassaro

Modified:
6 years, 8 months ago

Reviewers:
Nakaret1992, vadimsh, M-A Ruel, M-A

CC:
swarming-eng_googlegroups.com

Base URL:
https://code.google.com/p/swarming@master

Visibility:
Public.

More Reviews

Description

Added path to BotsService. Sigh. Test code looks at an API's resource_name, but real code looks at its path. R=maruel@chromium.org, vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=0dc852ad1da91f7d97b1035101890627b2a14c46

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	appengine/swarming/handlers_endpoints.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

cmassaro

On 2015/04/01 13:25:28, M-A wrote: > ^^ this was a speechless lgtm. Ah! Hahaha

10 years, 1 month ago (2015-04-01 16:08:18 UTC) #4

cmassaro

Committed patchset #1 (id:1) manually as 0dc852ad1da91f7d97b1035101890627b2a14c46 (presubmit successful).

10 years, 1 month ago (2015-04-01 16:11:44 UTC) #5

Nakaret1992

6 years, 8 months ago (2018-08-31 23:17:02 UTC) #6

Message was sent while issue was closed.

On 2015/04/01 16:11:44, cmassaro wrote:
> Committed patchset #1 (id:1) manually as
> 0dc852ad1da91f7d97b1035101890627b2a14c46 (presubmit successful).

Expand All Messages | Collapse All Messages