Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 217310044: ibus-ui-gtk3: Enable full path of engine icon in KDE5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by fujiwara
Modified:
9 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara, ftake_geeko.jp
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ibus-ui-gtk3: Enable absolute path of engine icon in KDE5 plasma-workspace 5.2 supports the icon full path. Now the build checks if qtbase-devel is 5.4 or later since there is no way to check the version of plasma-workspace. BUG=https://github.com/ibus/ibus/pull/17 TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Updated with the latest master. #

Patch Set 4 : Add AC_MSG_CHECKING in configure.ac #

Total comments: 4

Patch Set 5 : Updated with message #4. #

Patch Set 6 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M configure.ac View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download
M ui/gtk3/Makefile.am View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gtk3/panel.vala View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6
fujiwara
9 years, 2 months ago (2015-03-25 10:31:47 UTC) #1
Peng
https://codereview.appspot.com/217310044/diff/1/check_qt_module_pri.c File check_qt_module_pri.c (right): https://codereview.appspot.com/217310044/diff/1/check_qt_module_pri.c#newcode23 check_qt_module_pri.c:23: #include <libgen.h> what is this header for? https://codereview.appspot.com/217310044/diff/1/configure.ac File ...
9 years, 1 month ago (2015-03-30 16:28:24 UTC) #2
fujiwara
https://codereview.appspot.com/217310044/diff/1/check_qt_module_pri.c File check_qt_module_pri.c (right): https://codereview.appspot.com/217310044/diff/1/check_qt_module_pri.c#newcode23 check_qt_module_pri.c:23: #include <libgen.h> On 2015/03/30 16:28:24, Peng wrote: > what ...
9 years, 1 month ago (2015-03-31 06:49:25 UTC) #3
Peng
https://codereview.appspot.com/217310044/diff/60001/configure.ac File configure.ac (right): https://codereview.appspot.com/217310044/diff/60001/configure.ac#newcode587 configure.ac:587: SED=${SED:-sed} I saw AC_PROG_GREP & AC_PROG_SEC in /usr/share/autoconf/autoconf/programs.m4 Please ...
9 years, 1 month ago (2015-03-31 15:09:46 UTC) #4
fujiwara
https://codereview.appspot.com/217310044/diff/60001/configure.ac File configure.ac (right): https://codereview.appspot.com/217310044/diff/60001/configure.ac#newcode587 configure.ac:587: SED=${SED:-sed} On 2015/03/31 15:09:46, Peng wrote: > I saw ...
9 years, 1 month ago (2015-04-01 08:34:34 UTC) #5
Peng
9 years, 1 month ago (2015-04-01 20:16:14 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b