Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 217260043: Add means to display objects accessible from a grob

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by david.nalesnik
Modified:
4 years, 5 months ago
Reviewers:
ul, pwm, thomasmorley651
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Add means to display objects accessible from a grob A convenient means of displaying the grobs and grob-arrays pointed to by various internal properties of a given grob would be very helpful for debugging and development purposes. For example, it would facilitate the creation of advanced tweaks, which frequently require "lateral" access to other grobs. The output of the function 'grob::display-objects' shows all of the grobs accessible to a given grob through ly:grob-object, along with the relevant interfaces and properties. It includes properties which are empty: not all properties within an interface may be set for or used by a grob supporting that interface.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M scm/output-lib.scm View 1 chunk +38 lines, -0 lines 5 comments Download

Messages

Total messages: 9
david.nalesnik
Please review. Thanks!
4 years, 5 months ago (2015-03-24 16:38:52 UTC) #1
thomasmorley651
LGTM One question: https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) I always regretted ...
4 years, 5 months ago (2015-03-24 21:58:28 UTC) #2
david.nalesnik
https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: > ...
4 years, 5 months ago (2015-03-25 00:15:45 UTC) #3
david.nalesnik
https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/25 00:15:45, david.nalesnik wrote: > ...
4 years, 5 months ago (2015-03-25 01:13:20 UTC) #4
ul_openlilylib.org
>Well, it's not much code of course. Would it even be reloaded? >Anyway, >I wonder ...
4 years, 5 months ago (2015-03-25 05:35:28 UTC) #5
david.nalesnik
https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: > ...
4 years, 5 months ago (2015-03-25 13:59:20 UTC) #6
david.nalesnik
On 2015/03/25 05:35:28, ul_openlilylib.org wrote: > > > >Well, it's not much code of course. ...
4 years, 5 months ago (2015-03-25 14:11:34 UTC) #7
pwm
LGTM
4 years, 5 months ago (2015-03-26 01:15:52 UTC) #8
thomasmorley651
4 years, 5 months ago (2015-03-27 01:12:15 UTC) #9
https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165
scm/output-lib.scm:165: (use-modules (ice-9 pretty-print))
On 2015/03/25 13:59:20, david.nalesnik wrote:
> On 2015/03/24 21:58:28, thomasmorley651 wrote:
> > I always regretted that (ice-9 pretty-print) is not included per default. 
> > Is there any reason not to do so?
> 
> Looks like all that needs to be done is to add
> (use-modules (ice-9 pretty-print))
> to ly/init.ly
> 
> Then, pretty-print is available to ly files, including within music functions.
> 
> Shall I submit a patch?


Yes, would be great.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b