Issue 217115: code review 217115: Fix a couple of bugs referencing data values in template.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217115: code review 217115: Fix a couple of bugs referencing data values in template. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mstetson

Modified:
15 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

Fix a couple of bugs referencing data values in template. Adds tests and fixes for two cases that fail with the current release.

Patch Set 2 : code review 217115: Fix a couple of bugs referencing data values in template. #

Patch Set 3 : code review 217115: Fix a couple of bugs referencing data values in template. #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	src/pkg/template/template.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	src/pkg/template/template_test.go	View	1 2	4 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mstetson

http://codereview.appspot.com/217115/diff/1/2 File src/pkg/template/template.go (right): http://codereview.appspot.com/217115/diff/1/2#newcode627 src/pkg/template/template.go:627: data = intf.Elem() I'm not familiar enough with reflect ...

15 years ago (2010-02-24 09:57:04 UTC) #1

mstetson

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-02-26 00:27:40 UTC) #2

15 years ago (2010-02-26 07:39:52 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=7a3d2518b87d ***

Fix a couple of bugs referencing data values in template.

Adds tests and fixes for two cases that fail with the current release.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/217115

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages