Issue 217074: Constructor to create UriBuilder from an HttpServletRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217074: Constructor to create UriBuilder from an HttpServletRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by johnfargo

Modified:
15 years, 11 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

I believe this works fine but could use some insight into whether I'm missing edge cases.

Patch Set 1 #

Total comments: 1

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -2 lines)			Patch
		java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java	View		2 chunks	+16 lines, -0 lines	1 comment	Download
		java/common/src/test/java/org/apache/shindig/common/uri/UriBuilderTest.java	View		2 chunks	+64 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

http://codereview.appspot.com/217074/diff/1/3 File java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java (right): http://codereview.appspot.com/217074/diff/1/3#newcode68 java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java:68: (serverPort == 443 && "https".equals(scheme)) ? "" : To ...

15 years, 11 months ago (2010-02-22 17:52:19 UTC) #2

johnfargo

15 years, 11 months ago (2010-02-22 19:48:58 UTC) #3

Seems sensible to me. Added logic to accommodate this along w/ a new test,
and committed. Thanks!

On Mon, Feb 22, 2010 at 9:52 AM, <zhoresh@gmail.com> wrote:

>
> http://codereview.appspot.com/217074/diff/1/3
> File
>
> java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java
> (right):
>
> http://codereview.appspot.com/217074/diff/1/3#newcode68
> java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java:68:
> (serverPort == 443 && "https".equals(scheme)) ? "" :
> To be on the safe side, I will check also for port <=0 and don't specify
> port (for some reason I remember seeing -1 when port is not specified).
>
>
> http://codereview.appspot.com/217074/show
>

Expand All Messages | Collapse All Messages