Modified Request.Write to use RawURL, if given, otherwi...

Modified Request.Write to use RawURL, if given, otherwise use URL as before.

[rsc, 2010-02-22 22:55:19]

looks good, one nit

http://codereview.appspot.com/217066/diff/3/1002
File src/pkg/http/request.go (right):

http://codereview.appspot.com/217066/diff/3/1002#newcode155
src/pkg/http/request.go:155: //	URL
//        RawURL, if non-empty, or else URL

[petar-m, 2010-02-22 23:03:30]

Done

http://codereview.appspot.com/217066/diff/3/1002
File src/pkg/http/request.go (right):

http://codereview.appspot.com/217066/diff/3/1002#newcode155
src/pkg/http/request.go:155: //	URL
On 2010/02/22 22:55:19, rsc wrote:
> //        RawURL, if non-empty, or else URL
> 
> 

Done.

[rsc, 2010-02-22 23:39:27]

LGTM

i changed the spaces in the changed comment to a tab.
you might want to do that too to avoid a merge conflict.

[rsc, 2010-02-22 23:39:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=fc4c32b30734 ***

http: use RawURL in Request.Write

R=rsc
CC=golang-dev
http://codereview.appspot.com/217066

Committer: Russ Cox <rsc@golang.org>

[hoisie, 2010-02-23 18:10:11]

This doesn't seem right. uri should be the stuff after the slash, but it could
contain http:// . You could be requesting a hostname. 



On 2010/02/22 23:39:32, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=fc4c32b30734 ***
> 
> http: use RawURL in Request.Write
> 
> R=rsc
> CC=golang-dev
> http://codereview.appspot.com/217066
> 
> Committer: Russ Cox <mailto:rsc@golang.org>

[petar_csail.mit.edu, 2010-02-23 18:13:04]

I am not sure what you mean.

What we've done is simple:

If you want to bypass the URL encoding logic of the URL object,
you can just write the URL yourself in RawURL. If you don't
want to bypass it, then use URL.

Either way, it is your responsibility not to put bad data.
This just gives you more choices.

--Petar


On Tue, Feb 23, 2010 at 1:10 PM,  <hoisie@gmail.com> wrote:
> This doesn't seem right. uri should be the stuff after the slash, but it
> could contain http:// . You could be requesting a hostname.
>
>
>
> On 2010/02/22 23:39:32, rsc wrote:
>>
>> *** Submitted as
>
> http://code.google.com/p/go/source/detail?r=fc4c32b30734 ***
>
>> http: use RawURL in Request.Write
>
>> R=rsc
>> CC=golang-dev
>> http://codereview.appspot.com/217066
>
>> Committer: Russ Cox <mailto:rsc@golang.org>
>
>
>
> http://codereview.appspot.com/217066/show
>

[hoisie, 2010-02-23 18:26:02]

I guess I'm confused about the meaning of RawURL:

        var req http.Request
        req.Host = "google.com"
        req.RawURL = "http://www.google.com"

That writes out:

GET http://www.google.com HTTP/1.1
Host: google.com
User-Agent: Go http package

Which is malformed. 

On 2010/02/23 18:13:04, petar_csail.mit.edu wrote:
> I am not sure what you mean.
> 
> What we've done is simple:
> 
> If you want to bypass the URL encoding logic of the URL object,
> you can just write the URL yourself in RawURL. If you don't
> want to bypass it, then use URL.
> 
> Either way, it is your responsibility not to put bad data.
> This just gives you more choices.
> 
> --Petar
> 
> 
> On Tue, Feb 23, 2010 at 1:10 PM,  <mailto:hoisie@gmail.com> wrote:
> > This doesn't seem right. uri should be the stuff after the slash, but it
> > could contain http:// . You could be requesting a hostname.
> >
> >
> >
> > On 2010/02/22 23:39:32, rsc wrote:
> >>
> >> *** Submitted as
> >
> > http://code.google.com/p/go/source/detail?r=fc4c32b30734 ***
> >
> >> http: use RawURL in Request.Write
> >
> >> R=rsc
> >> CC=golang-dev
> >> http://codereview.appspot.com/217066
> >
> >> Committer: Russ Cox <mailto:rsc@golang.org>
> >
> >
> >
> > http://codereview.appspot.com/217066/show
> >
>

[rsc, 2010-02-23 18:29:51]

On Tue, Feb 23, 2010 at 10:26,  <hoisie@gmail.com> wrote:
> I guess I'm confused about the meaning of RawURL:
>
>        var req http.Request
>        req.Host = "google.com"
>        req.RawURL = "http://www.google.com"
>
> That writes out:
>
> GET http://www.google.com HTTP/1.1
> Host: google.com
> User-Agent: Go http package
>
> Which is malformed.

The definition of RawURL is whatever you want to put after the word GET.
If you put something malformed there, it will generate a malformed request.
It's that simple.

And, by the way, the request above is not malformed.
Not common perhaps, but definitely valid.

Russ