code review 217064: Count utf8 runes, not bytes when determining string wid...

Count utf8 runes, not bytes when determining string width. Note
that pad() still counts bytes, but it's currently only used for
1 byte runes.

Fixes issue 612.

[mnehpets, 2010-02-20 05:31:50]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-02-20 08:36:04]

See updated issue 612.

-rob

[r, 2010-02-22 03:48:27]

i'm inclined to take this if the doc comment is updated to state what padding
does.

[mnehpets, 2010-02-23 05:43:04]

How about %s -> width of string is counted as number of bytes, %#s -> width of
string is counted as number of runes?

[rsc, 2010-02-23 06:33:26]

# already has meaning, and this applies to every
format, not just %s.

Russ

[r2, 2010-02-23 07:12:29]

On 23/02/2010, at 5:33 PM, Russ Cox wrote:

> # already has meaning, and this applies to every
> format, not just %s.

Let's just go with your (Stephen's) original suggestion, plus documentation.

-rob

[mnehpets, 2010-02-28 02:18:20]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-02-28 02:26:31]

http://codereview.appspot.com/217064/diff/3001/3004
File src/pkg/fmt/print.go (right):

http://codereview.appspot.com/217064/diff/3001/3004#newcode47
src/pkg/fmt/print.go:47: of UTF-8 runes in the string. This differs from C's
printf where
i think the phrasing is a little ambiguous. how about
s/UTF-8 runes/Unicode code points/
finesses the issue of combining characters too.

[mnehpets, 2010-02-28 05:37:26]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-02-28 05:43:49]

LGTM

[r, 2010-02-28 10:16:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=9a458c87c6e7 ***

Count utf8 runes, not bytes when determining string width. Note
that pad() still counts bytes, but it's currently only used for
1 byte runes.

Fixes issue 612.

R=r
CC=golang-dev
http://codereview.appspot.com/217064

Committer: Rob Pike <r@golang.org>

[ken3, 2010-02-28 10:53:56]

shouldnt you be on a plane?

On Sun, Feb 28, 2010 at 2:16 AM,  <r@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=9a458c87c6e7 ***
>
> Count utf8 runes, not bytes when determining string width. Note
> that pad() still counts bytes, but it's currently only used for
> 1 byte runes.
>
> Fixes issue 612.
>
> R=r
> CC=golang-dev
> http://codereview.appspot.com/217064
>
> Committer: Rob Pike <r@golang.org>
>
>
> http://codereview.appspot.com/217064/show
>