Issue 217061: code review 217061: fixed bug in mpconst float multiply by 0.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217061: code review 217061: fixed bug in mpconst float multiply by 0. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by ken3

Modified:
14 years, 2 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

fixed bug in mpconst float multiply by 0. more complex -- constants, variables and print.

Patch Set 1 #

Patch Set 2 : code review 217061: fixed bug in mpconst float multiply by 0. #

Total comments: 1

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -28 lines)			Patch
M	src/cmd/6g/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6g/cgen.c	View		2 chunks	+8 lines, -0 lines	0 comments	Download
A	src/cmd/6g/cplx.c	View		1 chunk	+147 lines, -0 lines	0 comments	Download
M	src/cmd/6g/gg.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View		3 chunks	+32 lines, -0 lines	0 comments	Download
M	src/cmd/gc/const.c	View		4 chunks	+21 lines, -2 lines	0 comments	Download
M	src/cmd/gc/mparith1.c	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	src/cmd/gc/mparith3.c	View		4 chunks	+12 lines, -13 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/cmd/gc/walk.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/print.c	View	1	2 chunks	+13 lines, -0 lines	1 comment	Download
M	src/pkg/runtime/runtime.h	View	1	4 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-20 04:42:48 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=0df5f8df3a21 *** fixed bug in mpconst float multiply by 0. more complex ...

14 years, 2 months ago (2010-02-20 04:43:03 UTC) #2

rsc

14 years, 2 months ago (2010-02-22 23:24:33 UTC) #3

LGTM

http://codereview.appspot.com/217061/diff/14/25
File src/pkg/runtime/print.c (right):

http://codereview.appspot.com/217061/diff/14/25#newcode121
src/pkg/runtime/print.c:121: case 'C':
need a case 'C' in the switch above this one too,
to round arg and set narg.

Expand All Messages | Collapse All Messages