code review 2168043: Use OS rather than compiler specific flag the same way that

Use OS rather than compiler specific flag the same way that
__FreeBSD__, __APPLE__, __OpenBSD__, and __linux__ are used.

_WIN32 is defined by GCC (and others) on windows for Win32
and Win64 applications. _WIN32 is set by default for several
other windows based compilers: DMC, MSVC, Intel, Watcom, LCC.

Although the change is for consistency, it allows the Go tools
to be compiled with non-Mingw GCC distributions and non-GCC
compilers that support the GCC extensions.

[Joe Poirier, 2010-09-09 00:05:58]

Hello rsc, brainman, vcc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-09 02:05:16]

LGTM

[rsc, 2010-09-09 02:20:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=3a7564295618 ***

build: test for _WIN32, not _MINGW32

Use OS rather than compiler specific flag the same way that
__FreeBSD__, __APPLE__, __OpenBSD__, and __linux__ are used.

_WIN32 is defined by GCC (and others) on windows for Win32
and Win64 applications. _WIN32 is set by default for several
other windows based compilers: DMC, MSVC, Intel, Watcom, LCC.

Although the change is for consistency, it allows the Go tools
to be compiled with non-Mingw GCC distributions and non-GCC
compilers that support the GCC extensions.

R=rsc, brainman, vcc
CC=golang-dev
http://codereview.appspot.com/2168043

Committer: Russ Cox <rsc@golang.org>

[brainman, 2010-09-09 03:04:51]

LGTM