Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(149)

Issue 216350043: Major files refactoring - swarming. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by M-A
Modified:
9 years, 1 month ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming@master
Visibility:
Public.

Description

Major files refactoring - swarming. - Split main from handlers declaration for endpoints handlers. - Remove unnecessary imports. - Remove APP from mapreduce_jobs, it unnecessary. - Stop the forced logservice flushing, it's stable now. - Remove appstats, the new Clout Console Trace features can give meaningful data without require intervention from within the app. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=decb219c55a7566c2e3ec7135c3f2d9988ea8383

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Remove appstats #

Patch Set 3 : broken code :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -49 lines) Patch
M appengine/swarming/app.yaml View 1 2 chunks +6 lines, -3 lines 0 comments Download
M appengine/swarming/appengine_config.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M appengine/swarming/handlers_endpoints.py View 3 chunks +0 lines, -10 lines 0 comments Download
M appengine/swarming/handlers_endpoints_test.py View 3 chunks +4 lines, -11 lines 0 comments Download
M appengine/swarming/main.py View 1 2 2 chunks +13 lines, -17 lines 0 comments Download
M appengine/swarming/mapreduce_jobs.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5
M-A
The end goal is to make all 3 applications more similar. I'm sending separate CLs, ...
9 years, 1 month ago (2015-03-25 14:19:25 UTC) #1
vadimsh
lgtm https://codereview.appspot.com/216350043/diff/20001/appengine/swarming/main.py File appengine/swarming/main.py (right): https://codereview.appspot.com/216350043/diff/20001/appengine/swarming/main.py#newcode42 appengine/swarming/main.py:42: frontend = recording.appstats_wsgi_middleware(frontend) we should remove it completely. ...
9 years, 1 month ago (2015-03-25 21:35:22 UTC) #2
M-A
All references to appstats removed. https://codereview.appspot.com/216350043/diff/20001/appengine/swarming/main.py File appengine/swarming/main.py (right): https://codereview.appspot.com/216350043/diff/20001/appengine/swarming/main.py#newcode42 appengine/swarming/main.py:42: frontend = recording.appstats_wsgi_middleware(frontend) On ...
9 years, 1 month ago (2015-03-26 13:07:03 UTC) #3
M-A
Committed patchset #3 (id:60001) manually as decb219c55a7566c2e3ec7135c3f2d9988ea8383 (presubmit successful).
9 years, 1 month ago (2015-03-26 13:39:58 UTC) #4
M-A
9 years, 1 month ago (2015-03-26 13:53:17 UTC) #5
Message was sent while issue was closed.
On 2015/03/26 13:39:58, M-A wrote:
> Committed patchset #3 (id:60001) manually as
> decb219c55a7566c2e3ec7135c3f2d9988ea8383 (presubmit successful).

 Sorry for the 'Clout' typo in CL description.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b