code review 2163042: spec: Allow omission of low slice bound

spec: Allow omission of low slice bound

See also http://codereview.appspot.com/1957045/

[bytbox, 2010-09-07 20:37:56]

Hello gri, rsc1, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-09-07 20:44:14]

LGTM technically.

The English phrasing can probably be improved. Russ, Rob?
- gri

http://codereview.appspot.com/2163042/diff/5001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/2163042/diff/5001/doc/go_spec.html#newcode2456
doc/go_spec.html:2456: For convenience, either one or both of the index
expression may be
s/expression/expressions/

[bytbox, 2010-09-07 20:55:07]

Hello gri, rsc1, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-09-07 21:01:55]

http://codereview.appspot.com/2163042/diff/11001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/2163042/diff/11001/doc/go_spec.html#newcode2456
doc/go_spec.html:2456: For convenience, either one or both of the index
expressions may be
s/one // 
or even better
s/either one or both/any/

http://codereview.appspot.com/2163042/diff/11001/doc/go_spec.html#newcode2459
doc/go_spec.html:2459: <code>a[lo : len(a)]</code>, and <code>a[0 :
len(a)]</code> respectively.
'respectively' is a good indicator of a sentence that needs rewriting. in this
case you've got too many cases listed.  after the 'convenience' sentence, just
state the facts.

A missing low index defaults to zero, while a missing high index defaults to the
length of the array, slice, or string.

http://codereview.appspot.com/2163042/diff/11001/doc/go_spec.html#newcode2461
doc/go_spec.html:2461: For arrays or strings, the indexes <code>lo</code> and
<code>hi</code> must
put a <p> before this sentence.
also while we're here let's use english words: s/lo/low/ and s/hi/high/

[bytbox, 2010-09-07 21:06:35]

Hello gri, rsc1, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-09-07 21:09:22]

http://codereview.appspot.com/2163042/diff/15001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/2163042/diff/15001/doc/go_spec.html#newcode2460
doc/go_spec.html:2460: For arrays or strings, the indexes <code>low</code> and
<code>high</code> must
i still want a <p> in here.

[bytbox, 2010-09-07 21:10:24]

Hello gri, rsc1, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-09-07 21:12:43]

LGTM

rsc?

[rsc1, 2010-09-07 21:16:14]

LGTM

leaving for gri to submit

[gri, 2010-09-07 21:30:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=2031c0417645 ***

spec: Allow omission of low slice bound

See also http://codereview.appspot.com/1957045/

R=gri, rsc, r
CC=golang-dev
http://codereview.appspot.com/2163042

Committer: Robert Griesemer <gri@golang.org>