Issue 21610044: Proof bundles during ingest.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21610044: Proof bundles during ingest.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bac

Modified:
11 years, 5 months ago

Reviewers:
rharding, mp+193852

Visibility:
Public.

Description

Proof bundles during ingest. Changes related to charm-tools: * Upgrade to v 1.1.2 * Manage new dependencies * Use new charmtools.proof.proof signature * Reject bundles (baskets really) that fail proof during ingest. https://code.launchpad.net/~bac/charmworld/ingest-proof/+merge/193852 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -48 lines)			Patch
M	Makefile	View	1 chunk	+1 line, -1 line	2 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/jobs/ingest.py	View	2 chunks	+13 lines, -5 lines	2 comments	Download
M	charmworld/jobs/tests/test_ingest.py	View	5 chunks	+84 lines, -39 lines	0 comments	Download
M	charmworld/jobs/tests/test_proof.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	charmworld/views/api/proof.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	requirements.txt	View	3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

reviewer notes https://codereview.appspot.com/21610044/diff/1/Makefile File Makefile (left): https://codereview.appspot.com/21610044/diff/1/Makefile#oldcode74 Makefile:74: then - sudo ln -s /usr/bin/nodejs /usr/bin/node; ...

11 years, 5 months ago (2013-11-04 21:36:03 UTC) #2

rharding

11 years, 5 months ago (2013-11-04 21:41:40 UTC) #3

LGTM, we should at least log that things failed proof until we can get that into
the proof error page so that when users ask us why their stuff hasn't been
ingested we can trace/find it.

Notes below.

https://codereview.appspot.com/21610044/diff/1/Makefile
File Makefile (left):

https://codereview.appspot.com/21610044/diff/1/Makefile#oldcode74
Makefile:74: then - sudo ln -s /usr/bin/nodejs /usr/bin/node; \
On 2013/11/04 21:36:03, bac wrote:
> why was this ever here?
> was it to reject failure?
> 
> maybe -sudo

Because depending on what version of the OS you're on you get an older/newer
nodejs. In one case you get /usr/bin/node and in another /usr/bin/nodejs. This
was done to make them the same, but if it fails (because there is no
/usr/bin/nodejs) then just fail silently. It's ok.

Expand All Messages | Collapse All Messages