Issue 216045: Safe json parsing for caja code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 216045: Safe json parsing for caja code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by Jasvir

Modified:
15 years, 10 months ago

Reviewers:
johnfargo, Paul Lindner

CC:
shindig.remailer_gmail.com

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

* binds safejson to gadgets.json.stringify which skips over caja specific properties and only serializes properties a gadget has access to. * use json_sans_eval to parse json rather than eval @916013

Patch Set 1 #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -10 lines)			Patch
M	features/src/main/javascript/features/caja/taming.js	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	features/src/main/javascript/features/core.json/taming.js	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/core.log/taming.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java	View	2 chunks	+11 lines, -0 lines	0 comments	Download
A	java/server/src/test/resources/endtoend/jsonTest.xml	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Paul Lindner

15 years, 10 months ago (2010-02-24 21:46:29 UTC) #2

lgtm, although I can't comment on the caja usages.  Thanks for fixing up the
core.log taming.js

Expand All Messages | Collapse All Messages