Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 216044: Fix error trapping in embedded modules. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by MikeSamuel
Modified:
16 years, 1 month ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Cajita keeps track, in the module handler of the outcome of the last module. The same module handler is used to handle the modules a module loads. The lastOutcome variable is shared state across modules which means that the outer modules result is not independent of any modules it loads. This fixes that by using a local variable inside the handle function to store intermediate results. The problem arises because lastOutcome is set on both sides of the call to newModule.instantiate. Submitted @3988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/com/google/caja/cajita.js View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 1 month ago (2010-02-19 02:38:08 UTC) #1
MarkM
16 years, 1 month ago (2010-02-19 03:55:52 UTC) #2
Good point!

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b