Issue 2158043: code review 2158043: http: Drop the memoization in CanonicalHeaderKey (due t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2158043: code review 2158043: http: Drop the memoization in CanonicalHeaderKey (due t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by madari

Modified:
14 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: Drop the memoization in CanonicalHeaderKey (due to a security vulnerability). Fixes issue 1080.

Patch Set 2 : code review 2158043: http: Drop the memoization in CanonicalHeaderKey (due t... #

Total comments: 1

Patch Set 3 : code review 2158043: http: Drop the memoization in CanonicalHeaderKey (due t... #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	src/pkg/http/request.go	View	1 2	2 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

madari

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-09-07 18:58:21 UTC) #1

rsc1

Nice, thanks. http://codereview.appspot.com/2158043/diff/2001/src/pkg/http/request.go File src/pkg/http/request.go (right): http://codereview.appspot.com/2158043/diff/2001/src/pkg/http/request.go#newcode397 src/pkg/http/request.go:397: for i, v := range s { ...

14 years, 6 months ago (2010-09-07 19:15:43 UTC) #2

madari

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 6 months ago (2010-09-08 04:45:14 UTC) #3

rsc

14 years, 6 months ago (2010-09-08 14:20:23 UTC) #4

*** Submitted as c3b907276edb ***

http: do not cache CanonicalHeaderKey

Fixes issue 1080.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2158043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages