Issue 215660043: Added stats to Endpoints API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 215660043: Added stats to Endpoints API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by cmassaro

Modified:
9 years, 4 months ago

Reviewers:
vadimsh, M-A

CC:
swarming-eng_googlegroups.com

Base URL:
https://chromium.googlesource.com/infra/swarming.git@master

Visibility:
Public.

More Reviews

Description

Added stats to Endpoints API. R=maruel@chromium.org, vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=244a9d760df0a79ee59508dd94f3afbbf886d25b

Patch Set 2 : Used 0 Default #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	appengine/isolate/endpoint_handlers_api.py	View	1	3 chunks	+20 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

M-A

lgtm with question https://codereview.appspot.com/215660043/diff/1/appengine/isolate/endpoint_handlers_api.py File appengine/isolate/endpoint_handlers_api.py (right): https://codereview.appspot.com/215660043/diff/1/appengine/isolate/endpoint_handlers_api.py#newcode237 appengine/isolate/endpoint_handlers_api.py:237: offset = request.offset or 0 Why ...

9 years, 4 months ago (2015-03-25 21:08:44 UTC) #2

cmassaro

https://codereview.appspot.com/215660043/diff/1/appengine/isolate/endpoint_handlers_api.py File appengine/isolate/endpoint_handlers_api.py (right): https://codereview.appspot.com/215660043/diff/1/appengine/isolate/endpoint_handlers_api.py#newcode237 appengine/isolate/endpoint_handlers_api.py:237: offset = request.offset or 0 On 2015/03/25 21:08:44, M-A ...

9 years, 4 months ago (2015-03-25 21:11:49 UTC) #3

cmassaro

9 years, 4 months ago (2015-03-25 21:12:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
244a9d760df0a79ee59508dd94f3afbbf886d25b (presubmit successful).

Expand All Messages | Collapse All Messages