Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 2156046: code review 2156046: test: Match gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by iant
Modified:
14 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

test: Match gccgo error messages. bug298.go:10:2: error: expected declaration bug298.go:10:25: error: expected ‘;’ or newline after top level declaration bug298.go:10:25: error: expected declaration

Patch Set 1 #

Patch Set 2 : code review 2156046: test: Match gccgo error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/fixedbugs/bug298.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 6 months ago (2010-09-08 18:38:55 UTC) #1
rsc
LGTM
14 years, 6 months ago (2010-09-08 20:32:33 UTC) #2
iant
14 years, 6 months ago (2010-09-08 20:57:14 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=03989c2a3152 ***

test: Match gccgo error messages.

bug298.go:10:2: error: expected declaration
bug298.go:10:25: error: expected ‘;’ or newline after top level declaration
bug298.go:10:25: error: expected declaration

R=rsc
CC=golang-dev
http://codereview.appspot.com/2156046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b