code review 2154041: cgo: silence warning for C call returning const pointer

cgo: silence warning for C call returning const pointer

Fix suggested by Albert Strasheim.

[rsc, 2010-09-03 15:06:00]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-09-06 01:37:55]

LGTM

On 4 September 2010 01:06,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> cgo: silence warning for C call returning const pointer
>
> Fix suggested by Albert Strasheim.
>
> Please review this at http://codereview.appspot.com/2154041/
>
> Affected files:
>  M src/cmd/cgo/out.go
>
>
> Index: src/cmd/cgo/out.go
> ===================================================================
> --- a/src/cmd/cgo/out.go
> +++ b/src/cmd/cgo/out.go
> @@ -107,7 +107,11 @@
>                        fmt.Fprintf(&buf, "\t\tchar __pad%d[%d];\n", off,
> pad)
>                        off += pad
>                }
> -               fmt.Fprintf(&buf, "\t\t%s r;\n", t.C)
> +               qual := ""
> +               if t.C[len(t.C)-1] == '*' {
> +                       qual = "const "
> +               }
> +               fmt.Fprintf(&buf, "\t\t%s%s r;\n", qual, t.C)
>                off += t.Size
>        }
>        if off%p.PtrSize != 0 {
>
>
>

[rsc, 2010-09-07 13:54:30]

*** Submitted as 2b8b8fa37bf1 ***

cgo: silence warning for C call returning const pointer

Fix suggested by Albert Strasheim.

R=adg
CC=golang-dev
http://codereview.appspot.com/2154041