Standardize skip_files to test_.+; rename support to test_support.

appengine/auth_service/PRESUBMIT.py

 # Copyright 2014 The Swarming Authors. All rights reserved.
 # Use of this source code is governed by the Apache v2.0 license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for auth server.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into gcl.
 """
 
 
 def FindAppEngineSDK(input_api):
   """Returns an absolute path to AppEngine SDK (or None if not found)."""
   import sys
   old_sys_path = sys.path
   try:
     # Add 'components' to sys.path to be able to import gae_sdk_utils.
     components_dir = input_api.os_path.join(
         input_api.PresubmitLocalPath(), '..', 'components')
     sys.path = [components_dir] + sys.path
     # pylint: disable=F0401
-    from support import gae_sdk_utils
+    from test_support import gae_sdk_utils

[vadimsh, 2015/03/19 06:01:01]

gae_sdk_utils is mostly unrelated to testing :( It is used from "gae.py" tool.
That's the reason I called it "support" in a first place (instead of
"testing_tools" for example), because it's not just for testing. It is a code
that supports development activities (testing, tooling), but not to be deployed
with components. I do not like putting gae_sdk_utils.py into "test_support".

"support" and "components" together look nice: you make a symlink to both, and
use "support" from tests and tools (and blacklist it in app.yaml), and deploy
"components". I don't see why it is any worse than "test_support" that
inconsistently includes code not related to testing.

[M-A, 2015/03/19 14:50:10]

Ok so I split "support" in two:
- tool_support
- test_support

I added README.md to each to explain the difference. wdyt?
I agree that strictly speaking, we do not need to separate both but I think it's
nice to clarify this separation long term even if it is for 2 files.
The main downside is that now there will be one more symlink.

     return gae_sdk_utils.find_gae_sdk()
   finally:
     sys.path = old_sys_path
 
 
 def CommonChecks(input_api, output_api):
   output = []
   def join(*args):
     return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
 
@@ skipping 36 matching lines @@
   output.extend(input_api.RunTests(tests, parallel=True))
   return output
 
 
 def CheckChangeOnUpload(input_api, output_api):
   return CommonChecks(input_api, output_api)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   return CommonChecks(input_api, output_api)