Issue 215047: Handle bad url in concat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 215047: Handle bad url in concat

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by zhoresh

Modified:
15 years, 11 months ago

Reviewers:
johnfargo, shindig.remailer

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Skip bad url in concat, and provide usable error. The ServletOutputStream.print support ascii only, so if the url has bad characters an exception is thrown. The fix uses write of utf-8 string for the error message.

Patch Set 1 #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -11 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java	View		4 chunks	+18 lines, -9 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ConcatProxyServletTest.java	View		3 chunks	+48 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

15 years, 11 months ago (2010-02-19 19:05:11 UTC) #2

Looks good Ziv. I've committed this CL (r911933) with just a few minor tweaks:

* Changed IllegalArgumentException to Uri.UriException
* Used uri.toString() as the new value for url to be doubly-sure that the Uri's
formatting is OK.

Expand All Messages | Collapse All Messages