Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 2150044: code review 2150044: test: Recognize gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by iant
Modified:
14 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

test: Recognize gccgo error messages. bug299.go:16:2: error: expected field name bug299.go:17:2: error: expected field name bug299.go:18:3: error: expected field name bug299.go:25:9: error: expected receiver name or type bug299.go:26:10: error: expected receiver name or type bug299.go:27:9: error: expected receiver name or type

Patch Set 1 #

Patch Set 2 : code review 2150044: test: Recognize gccgo error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/fixedbugs/bug299.go View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 6 months ago (2010-09-08 18:54:17 UTC) #1
rsc
LGTM
14 years, 6 months ago (2010-09-08 20:32:46 UTC) #2
iant
14 years, 6 months ago (2010-09-08 20:58:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e6167254e2a3 ***

test: Recognize gccgo error messages.

bug299.go:16:2: error: expected field name
bug299.go:17:2: error: expected field name
bug299.go:18:3: error: expected field name
bug299.go:25:9: error: expected receiver name or type
bug299.go:26:10: error: expected receiver name or type
bug299.go:27:9: error: expected receiver name or type

R=rsc
CC=golang-dev
http://codereview.appspot.com/2150044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b