src/pkg/runtime/darwin/mem.c - Issue 2150042: code review 2150042: runtime: use manual stack for garbage collection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/pkg/runtime/darwin/mem.c

Issue 2150042: code review 2150042: runtime: use manual stack for garbage collection (Closed)

Left Patch Set: code review 2150042: runtime: use manual stack for garbage collection Created 14 years, 6 months ago

Right Patch Set: code review 2150042: runtime: use manual stack for garbage collection Created 14 years, 6 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
(Both sides are equal)
1 #include "runtime.h"	1 #include "runtime.h"

2 #include "defs.h"	2 #include "defs.h"

3 #include "os.h"	3 #include "os.h"

4 #include "malloc.h"	4 #include "malloc.h"

5	5

6 void*	6 void*

7 SysAlloc(uintptr n)	7 SysAlloc(uintptr n)

8 {	8 {

9 mstats.sys += n;	9 mstats.sys += n;

10 return runtime_mmap(nil, n, PROT_READ\|PROT_WRITE\|PROT_EXEC, MAP_ANON\|MAP _PRIVATE, -1, 0);	10 return runtime_mmap(nil, n, PROT_READ\|PROT_WRITE\|PROT_EXEC, MAP_ANON\|MAP _PRIVATE, -1, 0);

11 }	11 }

12	12

13 void	13 void

14 SysUnused(void *v, uintptr n)	14 SysUnused(void *v, uintptr n)

15 {	15 {

16 USED(v);	16 USED(v);

17 USED(n);	17 USED(n);

18 // TODO(rsc): call madvise MADV_DONTNEED	18 // TODO(rsc): call madvise MADV_DONTNEED

19 }	19 }

20	20

21 void	21 void

22 SysFree(void *v, uintptr n)	22 SysFree(void *v, uintptr n)

23 {	23 {

24 runtime_munmap(v, n);	24 runtime_munmap(v, n);

25 }	25 }

26	26

LEFT	RIGHT