Issue 214550045: Move endpoints_smoke_test.py out of components/*.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 214550045: Move endpoints_smoke_test.py out of components/*. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by vadimsh

Modified:
10 years, 1 month ago

Reviewers:
M-A

CC:
swarming-eng_googlegroups.com

Base URL:
https://code.google.com/p/swarming@master

Visibility:
Public.

More Reviews

Description

Move endpoints_smoke_test.py out of components/*. It creates a symbolic link cycle that confuses appcfg.py. R=maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=3ef1b180c9f3f2fbb171265648632b3cce4986d3

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -188 lines)			Patch
M	appengine/components/PRESUBMIT.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download
D	appengine/components/components/auth/endpoints_smoke_test.py	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	appengine/components/components/auth/test_endpoints_app/app.yaml	View		1 chunk	+0 lines, -25 lines	0 comments	Download
D	appengine/components/components/auth/test_endpoints_app/components	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	appengine/components/components/auth/test_endpoints_app/main.py	View		1 chunk	+0 lines, -70 lines	0 comments	Download
A	appengine/components/tests/README.md	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	appengine/components/tests/endpoints_smoke_test.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	appengine/components/tests/test_endpoints_app/app.yaml	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	appengine/components/tests/test_endpoints_app/components	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	appengine/components/tests/test_endpoints_app/main.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	appengine/components/tests/tool_support	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

M-A

lgtm, thanks https://codereview.appspot.com/214550045/diff/1/appengine/components/tests/README.md File appengine/components/tests/README.md (right): https://codereview.appspot.com/214550045/diff/1/appengine/components/tests/README.md#newcode1 appengine/components/tests/README.md:1: This directory contains smoke test that uses ...

10 years, 1 month ago (2015-03-24 12:47:45 UTC) #2

vadimsh

https://codereview.appspot.com/214550045/diff/1/appengine/components/tests/README.md File appengine/components/tests/README.md (right): https://codereview.appspot.com/214550045/diff/1/appengine/components/tests/README.md#newcode1 appengine/components/tests/README.md:1: This directory contains smoke test that uses components/*. Such ...

10 years, 1 month ago (2015-03-24 20:39:21 UTC) #3

vadimsh

10 years, 1 month ago (2015-03-24 20:40:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3ef1b180c9f3f2fbb171265648632b3cce4986d3 (presubmit successful).

Expand All Messages | Collapse All Messages