Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 2145042: Taming policy fixes for ES53 in the playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by Jasvir
Modified:
15 years, 9 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Makes the policy tab work for both ES53 and Valija mode * Relabel Valija to ES3 * cssparser.js fix for [^] regex on IE @4290

Patch Set 1 #

Total comments: 1

Patch Set 2 : Taming policy fixes for ES53 in the playground #

Total comments: 4

Patch Set 3 : Taming policy fixes for ES53 in the playground #

Patch Set 4 : Taming policy fixes for ES53 in the playground #

Patch Set 5 : Taming policy fixes for ES53 in the playground #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -32 lines) Patch
M src/com/google/caja/demos/playground/client/policy.js View 2 3 2 chunks +8 lines, -17 lines 0 comments Download
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/com/google/caja/demos/playground/es53.html View 1 2 3 4 2 chunks +16 lines, -5 lines 0 comments Download
M src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M src/com/google/caja/demos/playground/taming.js View 1 2 3 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 6
Jasvir
15 years, 9 months ago (2010-09-08 06:27:31 UTC) #1
Jasvir
http://codereview.appspot.com/2145042/diff/1/src/com/google/caja/plugin/cssparser.js File src/com/google/caja/plugin/cssparser.js (right): http://codereview.appspot.com/2145042/diff/1/src/com/google/caja/plugin/cssparser.js#newcode73 src/com/google/caja/plugin/cssparser.js:73: var STRING1 = '"(?:[^\\"\\\\]|\\\\[\s\S])*"'; IE does not recognize [^] ...
15 years, 9 months ago (2010-09-08 06:30:25 UTC) #2
metaweta
LGTM http://codereview.appspot.com/2145042/diff/5001/src/com/google/caja/demos/playground/es53.html File src/com/google/caja/demos/playground/es53.html (right): http://codereview.appspot.com/2145042/diff/5001/src/com/google/caja/demos/playground/es53.html#newcode60 src/com/google/caja/demos/playground/es53.html:60: imports.outers = imports; Why did this get added ...
15 years, 9 months ago (2010-09-21 22:47:33 UTC) #3
Jasvir
http://codereview.appspot.com/2145042/diff/5001/src/com/google/caja/demos/playground/es53.html File src/com/google/caja/demos/playground/es53.html (right): http://codereview.appspot.com/2145042/diff/5001/src/com/google/caja/demos/playground/es53.html#newcode60 src/com/google/caja/demos/playground/es53.html:60: imports.outers = imports; policy.js requires it while we're supporting ...
15 years, 9 months ago (2010-09-21 23:47:21 UTC) #4
Jasvir
Leaving the taming loop in the host page results in errors (and browser crashes) so ...
15 years, 9 months ago (2010-09-28 00:07:32 UTC) #5
metaweta
15 years, 9 months ago (2010-09-28 00:32:40 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b