Serve cached stale data if receiveing external server error for a resource

If we have data for a resource, lets serve it even if it stale in cases that the external resource is not available.
Only serve non error pages, and only for server error (>=500)

[chirag, 2010-02-19 07:06:36]

http://codereview.appspot.com/214045/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
(right):

http://codereview.appspot.com/214045/diff/1/4#newcode240
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:240:
return true;
Could be simplified to return response != null

[johnfargo, 2010-02-19 19:18:06]

Nothing new here. We need a DefaultRequestPipelineTest though.

http://codereview.appspot.com/214045/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
(right):

http://codereview.appspot.com/214045/diff/1/4#newcode240
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:240:
return true;
+1

http://codereview.appspot.com/214045/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
(right):

http://codereview.appspot.com/214045/diff/1/2#newcode57
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java:57:
HttpResponse staledResponse = null;
nit: s/staled/stale/

[zhoresh, 2010-02-19 22:56:34]

Fixed according to comments and added tests.

[johnfargo, 2010-02-20 03:54:17]

Thanks for the test, looks great.

Committed.

On Fri, Feb 19, 2010 at 2:56 PM, <zhoresh@gmail.com> wrote:

> Fixed according to comments and added tests.
>
>
> http://codereview.appspot.com/214045/show
>