Issue 214042: code review 214042: new types complex, complex64 and complex128

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 214042: code review 214042: new types complex, complex64 and complex128 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by ken3

Modified:
14 years, 2 months ago

Reviewers:
Charlie Dorian

CC:
rsc, golang-dev

Visibility:
Public.

Description

new types complex, complex64 and complex128 only front-end compiler work. best to do thin in 3 steps 1. frontend 2. backend 3. lib

Patch Set 2 : code review 214042: new types complex, complex64 and complex128 #

Total comments: 1

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+286 lines, -57 lines)			Patch
M	src/cmd/6g/galign.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/align.c	View	4 chunks	+22 lines, -2 lines	0 comments	Download
M	src/cmd/gc/const.c	View	17 chunks	+174 lines, -39 lines	0 comments	Download
M	src/cmd/gc/go.h	View	5 chunks	+21 lines, -7 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	6 chunks	+27 lines, -0 lines	0 comments	Download
M	src/cmd/gc/print.c	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	4 chunks	+19 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/type.go	View	1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-18 06:08:29 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=dc4bb513d292 *** new types complex, complex64 and complex128 only front-end compiler work. ...

14 years, 2 months ago (2010-02-18 06:08:37 UTC) #2

Charlie Dorian

Found typo. http://codereview.appspot.com/214042/diff/11/1018 File src/pkg/runtime/type.go (right): http://codereview.appspot.com/214042/diff/11/1018#newcode105 src/pkg/runtime/type.go:105: // Complex128Type represents a complex32 type. complex128 ...

14 years, 2 months ago (2010-02-18 07:33:08 UTC) #4

ken3

14 years, 2 months ago (2010-02-18 07:35:37 UTC) #5

complex 128 is 2*float64, it is the whole width, not
the width of the individuals.

On Wed, Feb 17, 2010 at 11:33 PM,  <cldorian@gmail.com> wrote:
> Found typo.
>
>
> http://codereview.appspot.com/214042/diff/11/1018
> File src/pkg/runtime/type.go (right):
>
> http://codereview.appspot.com/214042/diff/11/1018#newcode105
> src/pkg/runtime/type.go:105: // Complex128Type represents a complex32
> type.
> complex128 for complex32
>
> http://codereview.appspot.com/214042/show
>

Expand All Messages | Collapse All Messages