Generics Support - trying out rietveld code reviewer

Added support for injected generic services. You can now implement the same service interface multiple times with different type parameters, and inject it using the generic interface.
Made Loop generic and added public getters for index and value. No more need to add properties to the page or use the var binding for simple object rendering loops.
Updated PropertyWorker, Transform* to copy generic field signature to created getter.
Updated GenericsUtils/PropertyConduitSourceImpl to more fully support wildcard and parameterized types.
Added tests for everything

[joshcanfield, 2010-09-14 06:16:53]

Fixed NPE with interfaces. Fixed support for methods with synthetic versions.

[joshcanfield, 2010-09-16 03:59:05]

I'll soon have the power to check this in. There are two places that I'd like to
get eyes on because they involve changes to public interfaces.

Thanks,
Josh

http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
File tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java
(right):

http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java:83: <T> T
getService(Class<T> serviceInterface, Type genericType);
Change to public interface. It could possibly be moved into a
GenericObjectLocator. Is this an interface that people actively implement?

http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
File
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java
(right):

http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java:58:
<T> T provide(Class<T> objectType, Type genericType, AnnotationProvider
annotationProvider, ObjectLocator locator, boolean required);
Modified public interface; Changed method signature instead of adding a new
signature. Tapestry Core uses it in DefaultInjectionProvider and IOC uses it in
the Registry. Is there user code out there that uses this?

[igor.drobiazko_gmail.com, 2010-09-16 07:03:10]

Hm, 5.2.0 is an alpha release and we should concentrate on bug fixing.
Adding new features would probably delay the stable release. Would you mind
to wait until 5.3-SNAPSHOTS?

Your patch chnages some public API in a incompatibly way and I would like to
discuss it first. Hope to find some time today later to send you some
comments.

On Thu, Sep 16, 2010 at 5:59 AM, <joshcanfield@gmail.com> wrote:

> I'll soon have the power to check this in. There are two places that I'd
> like to get eyes on because they involve changes to public interfaces.
>
> Thanks,
> Josh
>
>
>
>
http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
> File
>
> tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java
> (right):
>
>
>
http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
> tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java:83:
> <T> T getService(Class<T> serviceInterface, Type genericType);
> Change to public interface. It could possibly be moved into a
> GenericObjectLocator. Is this an interface that people actively
> implement?
>
>
>
http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
> File
>
>
>
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java
> (right):
>
>
>
http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/o...
>
>
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java:58:
> <T> T provide(Class<T> objectType, Type genericType, AnnotationProvider
> annotationProvider, ObjectLocator locator, boolean required);
> Modified public interface; Changed method signature instead of adding a
> new signature. Tapestry Core uses it in DefaultInjectionProvider and IOC
> uses it in the Registry. Is there user code out there that uses this?
>
>
> http://codereview.appspot.com/2140047/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Best regards,

Igor Drobiazko
http://tapestry5.de

[T van Dijk, 2010-11-05 12:24:16]

http://codereview.appspot.com/2140047/diff/17001/tapestry-core/src/main/java/...
File
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultInjectionProvider.java
(right):

http://codereview.appspot.com/2140047/diff/17001/tapestry-core/src/main/java/...
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultInjectionProvider.java:60:
Object injectionValue = masterObjectProvider.provide(fieldType, null, field,
this.locator, false);
I wonder if the object shouldn't be provided by ObjectLocator.getObject instead
of directly from the master object provider. ObjectLocator first checks for
matches of services with markers. The master object provider also includes
service overrides, which doesn't check seem to check markers. (I ran into this
with the multi db patch)