Issue 213760043: Add ibus_keyval_convert_case and ibus_keyval_to_upper/lower methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 213760043: Add ibus_keyval_convert_case and ibus_keyval_to_upper/lower methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 2 months ago by Peng Wu

Modified:
9 years, 2 months ago

Reviewers:
shawn.p.huang, fujiwara, Peng

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Add ibus_keyval_convert_case and ibus_keyval_to_upper/lower methods In some input method setup dialog, customization of shortcut keys are supported. But in python Gtk+, when grab the shortcut key, the gdk_keyval_to_lower method will be used. This patch adds ibus_keyval_convert_case and ibus_keyval_to_upper/lower methods, so ibus-libpinyin can drop the Gdk 3.x C++ dependency. BUG=https://code.google.com/p/ibus/issues/detail?id=1766 TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : export ibus_keyval_convert_case method #

Patch Set 3 : #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -0 lines)			Patch
	M	src/ibuskeynames.c	View	1 2	2 chunks	+147 lines, -0 lines	0 comments	Download
	M	src/ibuskeys.h	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fujiwara

https://codereview.appspot.com/213760043/diff/1/src/ibuskeynames.c File src/ibuskeynames.c (right): https://codereview.appspot.com/213760043/diff/1/src/ibuskeynames.c#newcode204 src/ibuskeynames.c:204: ibus_keyval_convert_case (keyval, NULL, &result); No declaration of ibus_keyval_convert_case() causes ...

9 years, 2 months ago (2015-03-05 08:36:41 UTC) #2

Committed.
Please close the CL.
Thanks.

Expand All Messages | Collapse All Messages