Issue 2135045: code review 2135045: runtime: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2135045: code review 2135045: runtime: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by brainman

Modified:
14 years, 6 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

runtime: fix windows build

Patch Set 1 #

Patch Set 2 : code review 2135045: runtime: fix windows build #

Patch Set 3 : code review 2135045: runtime: fix windows build #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1 line)			Patch
M	src/pkg/runtime/windows/mem.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/windows/os.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/thread.c	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-09-09 01:31:00 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=f8ff5a2edc3e *** runtime: fix windows build R=rsc, r2 CC=golang-dev http://codereview.appspot.com/2135045

14 years, 6 months ago (2010-09-09 02:09:14 UTC) #4

brainman

14 years, 6 months ago (2010-09-09 02:12:43 UTC) #5

> i was close...  :-)

I thought you never make mistakes! :-)

Alex

Expand All Messages | Collapse All Messages