Issue 2133042: PHP: SHINDIG-1144 broke data pipelining and client compatibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2133042: PHP: SHINDIG-1144 broke data pipelining and client compatibility

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by bashofmann

Modified:
10 years, 1 month ago

Reviewers:

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Commit 949663 for issue SHINDIG-1144 broke data pipelining in PHP as well as compatibility with older client libraries. In the last weeks we circumvented this locally by reverting this change, but here is now a clean path for this: - changed "data" keys to "result" in DataPipelining - Re-added /social/rpc endpoint which returns old "data" key

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+55 lines, -26 lines)			Patch
php/config/container.php	View	1 chunk	+2 lines, -1 line	0 comments	Download
php/src/gadgets/render/GadgetBaseRenderer.php	View	2 chunks	+7 lines, -7 lines	0 comments	Download
php/src/gadgets/templates/DataPipelining.php	View	3 chunks	+15 lines, -15 lines	0 comments	Download
php/src/social/servlet/CompatibilityJsonRpcServlet.php	View	1 chunk	+26 lines, -0 lines	0 comments	Download
php/src/social/servlet/JsonRpcServlet.php	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages