Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(573)

Issue 212600043: Allow cascades with repeated method names to be one line. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by jacobr
Modified:
9 years ago
Reviewers:
Bob Nystrom
CC:
John Messerly
Base URL:
git@github.com:dart-lang/dart_style.git@master
Visibility:
Public.

Description

Allow cascades with repeated method names to be one line. BUG= R=rnystrom@google.com Committed: 1195508ee8b9ca4135e15f333ef22d9c409e8bf6

Patch Set 1 #

Total comments: 15

Patch Set 2 : ptal #

Total comments: 2

Patch Set 3 : ptals #

Patch Set 4 : ptals #

Total comments: 1

Patch Set 5 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -14 lines) Patch
M CHANGELOG.md View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 2 3 4 1 chunk +26 lines, -7 lines 0 comments Download
M test/whitespace/cascades.stmt View 1 2 1 chunk +17 lines, -4 lines 0 comments Download
M test/whitespace/functions.unit View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7
jacobr
9 years ago (2015-03-20 19:24:24 UTC) #1
Bob Nystrom
https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart#newcode386 lib/src/source_visitor.dart:386: bool _consistentNames(NodeList<Expression> sections) { Let's call this "_allowInlineCascade". Also: ...
9 years ago (2015-03-20 19:59:41 UTC) #2
jacobr
ptal https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart#newcode386 lib/src/source_visitor.dart:386: bool _consistentNames(NodeList<Expression> sections) { On 2015/03/20 19:59:41, Bob ...
9 years ago (2015-03-20 20:20:53 UTC) #3
Bob Nystrom
You'll need to add this to the changelog too. https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart#newcode388 lib/src/source_visitor.dart:388: ...
9 years ago (2015-03-20 21:05:48 UTC) #4
jacobr
ptal https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): https://codereview.appspot.com/212600043/diff/1/lib/src/source_visitor.dart#newcode388 lib/src/source_visitor.dart:388: String name = null; On 2015/03/20 21:05:48, Bob ...
9 years ago (2015-03-20 23:16:09 UTC) #5
Bob Nystrom
Don't forget to add it to the changelog too, then LGTM. https://codereview.appspot.com/212600043/diff/60001/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): ...
9 years ago (2015-03-23 20:01:18 UTC) #6
jacobr
9 years ago (2015-03-23 21:18:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
1195508ee8b9ca4135e15f333ef22d9c409e8bf6 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b