Issue 2123045: HttpResponse.getCacheTtl returns time in milliseconds while ttl in cache headers is in seconds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2123045: HttpResponse.getCacheTtl returns time in milliseconds while ttl in cache headers is in seconds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Kuntal Loya

Modified:
15 years, 3 months ago

Reviewers:
Paul Lindner, dev, dev-remailer, zhoresh

CC:
cool-shindig-committers_googlegroups.com, gagan.goku, anupama.dutta

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

HttpResponse.getCacheTtl returns time in milliseconds while ttl in cache headers is in seconds, therefore doing the appropriate conversion.

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ServletUtil.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ServletUtilTest.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6

anupama.dutta

Is there any test that could be updated to verify this caching header value?

15 years, 4 months ago (2010-09-15 04:57:07 UTC) #2

anupama.dutta

Oops. Just saw Gagan's comment :) Thanks, Anupama. On Wed, Sep 15, 2010 at 10:27 ...

15 years, 4 months ago (2010-09-15 04:57:54 UTC) #3

lgtm too --- will commit.