Issue 2120042: [SHINDIG-1421] dynamic-height feature overestimates the height of gadgets that have elements with cl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2120042: [SHINDIG-1421] dynamic-height feature overestimates the height of gadgets that have elements with cl

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by mat.mannion

Modified:
11 years, 5 months ago

Reviewers:
henry.saputra, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This patch changes the Webkit height calculation to use offsetHeight instead of scrollHeight, and doesn't calculate for elements that are descendants of an element that clips its overflow.

Patch Set 1 #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
		features/src/main/javascript/features/dynamic-height/dynamic-height.js	View		1 chunk	+34 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

henry.saputra

Do you have sample gadget to test this patch? On 2010/09/06 09:00:57, mat.mannion wrote:

15 years, 5 months ago (2010-10-06 18:27:12 UTC) #2

mat.mannion

On 2010/10/06 18:27:12, henry.saputra wrote: > Do you have sample gadget to test this patch? ...

15 years, 5 months ago (2010-10-06 23:08:48 UTC) #3

henry.saputra

15 years, 5 months ago (2010-10-12 21:05:34 UTC) #5

Fix checkedin with 
svn commit: r1021919 -
/shindig/trunk/features/src/main/javascript/features/dynamic-height/dynamic-height.js

Thanks Mat.

Expand All Messages | Collapse All Messages