code review 2115042: goinstall: assume go binaries are in path

goinstall: assume go binaries are in path

(Following new convention.)

Fixes issue 1063.

[rsc, 2010-09-02 18:29:27]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-09-02 23:10:26]

LGTM

On Friday, September 3, 2010,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> goinstall: assume go binaries are in path
>
> (Following new convention.)
>
> Fixes issue 1063.
>
> Please review this at http://codereview.appspot.com/2115042/
>
> Affected files:
>   M src/cmd/goinstall/main.go
>   M src/cmd/goinstall/make.go
>
>
> Index: src/cmd/goinstall/main.go
> ===================================================================
> --- a/src/cmd/goinstall/main.go
> +++ b/src/cmd/goinstall/main.go
> @@ -29,7 +29,6 @@
>  var (
>         argv0         = os.Args[0]
>         errors        = false
> -       gobin         = os.Getenv("GOBIN")
>         parents       = make(map[string]string)
>         root          = runtime.GOROOT()
>         visit         = make(map[string]status)
> @@ -57,9 +56,6 @@
>                 fmt.Fprintf(os.Stderr, "%s: no $GOROOT\n", argv0)
>                 os.Exit(1)
>         }
> -       if gobin == "" {
> -               gobin = root + "/bin"
> -       }
>         root += "/src/pkg/"
>
>         // special case - "unsafe" is already installed
> Index: src/cmd/goinstall/make.go
> ===================================================================
> --- a/src/cmd/goinstall/make.go
> +++ b/src/cmd/goinstall/make.go
> @@ -21,14 +21,14 @@
>         if local {
>                 _, err := os.Stat(dir + "/Makefile")
>                 if err == nil {
> -                       return run(dir, nil, gobin+"/gomake", "install")
> +                       return run(dir, nil, "gomake", "install")
>                 }
>         }
>         makefile, err := makeMakefile(dir, pkg)
>         if err != nil {
>                 return err
>         }
> -       return run(dir, makefile, gobin+"/gomake", "-f-", "install")
> +       return run(dir, makefile, "gomake", "-f-", "install")
>  }
>
>  // makeMakefile computes the standard Makefile for the directory dir
>
>
>

[rsc, 2010-09-03 19:37:51]

*** Submitted as de460f8d593f ***

goinstall: assume go binaries are in path

(Following new convention.)

Fixes issue 1063.

R=adg
CC=golang-dev
http://codereview.appspot.com/2115042