Issue 2109042: Invalid container configuration property name is breaking OAuth 1.0a client support in Java Shindig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2109042: Invalid container configuration property name is breaking OAuth 1.0a client support in Java Shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by jcian

Modified:
15 years, 5 months ago

Reviewers:
bashofmann, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

In the Java Shindig implementation DefaultOAuthUriManager looks for a container configuration property called "gadgets.uri.oauth.callbackTemplate" which doesn't exist anywhere in the current codebase, however there is a property called "gadgets.oauthGadgetCallbackTemplate" in the default container.js file which is referenced in a few places by the PHP Shindig implementation. This patch renames the "gadgets.oauthGadgetCallbackTemplate" property to "gadgets.uri.oauth.callbackTemplate" (since the latter is more inline with the rest of the configuration property names) and updates the PHP usages accordingly. Note that I don't run PHP Shindig so I don't really have any way to test if anything broke on the PHP end.

Patch Set 1 #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
config/container.js	View	1 chunk	+1 line, -1 line	0 comments	Download
php/src/gadgets/ContainerConfig.php	View	1 chunk	+1 line, -1 line	0 comments	Download
php/test/gadgets/ContainerConfigTest.php	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

changes to php code look good

Expand All Messages | Collapse All Messages