Issue 2106044: Adding gagan as a shindig committer :)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2106044: Adding gagan as a shindig committer :) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by gagan.goku

Modified:
15 years, 4 months ago

Reviewers:
dev, chirag

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Adding myself as a shindig committer :)

Patch Set 1 #

Patch Set 2 : good_change #

Patch Set 3 : new_mac_rokx #

Patch Set 4 : svn_up #

Patch Set 5 : Generating_COMMITTERS_file_using_MVN-Pto-committers #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	COMMITTERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	pom.xml	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

gagan.goku

On 2010/09/02 03:35:31, anupama.dutta wrote: > LGTM :) Thanks for the thorough review Anupama.

15 years, 5 months ago (2010-09-02 03:36:07 UTC) #4

chirag

LGTM! The COMMITTERS file needs to be updated too. I think this can be done ...

15 years, 5 months ago (2010-09-02 04:01:37 UTC) #5

gagan.goku

It worked :) Please take a look now. On Thu, Sep 2, 2010 at 9:31 ...

15 years, 4 months ago (2010-09-02 19:53:16 UTC) #8

gagan.goku

15 years, 4 months ago (2010-09-03 06:47:35 UTC) #9

Committed.
Since no1 has sent me any hate / die mail yet :) , i think things are going to
be okay. Thanks to every1 for helping out.

On 2010/09/02 19:53:16, gagan.goku wrote:
> It worked :) Please take a look now.
> 
> On Thu, Sep 2, 2010 at 9:31 AM, <mailto:chiragshah1@gmail.com> wrote:
> 
> > LGTM! The COMMITTERS file needs to be updated too. I think this can be
> > done by running mvn -Pto-committers
> >
> >
> > On 2010/09/02 03:36:07, gagan.goku wrote:
> >
> >> On 2010/09/02 03:35:31, anupama.dutta wrote:
> >> > LGTM :)
> >>
> >
> >  Thanks for the thorough review Anupama.
> >>
> >
> >
> >
> > http://codereview.appspot.com/2106044/
> >
>

Expand All Messages | Collapse All Messages