code review 2104042: 8l: suppress emitting DWARF in Windows PE.

8l: suppress emitting DWARF in Windows PE.

Fixes issue 1064.

[brainman, 2010-09-01 02:43:28]

Hello rsc, lvd (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[lvd, 2010-09-01 12:00:38]

sorry about that.

1 comment below.

http://codereview.appspot.com/2104042/diff/2001/3001
File src/cmd/8l/asm.c (right):

http://codereview.appspot.com/2104042/diff/2001/3001#newcode1053
src/cmd/8l/asm.c:1053: dwarfaddheaders();
you probably want to disable this one too then.

[rsc, 2010-09-01 13:26:20]

LGTM

[vcc, 2010-09-01 16:33:04]

I make a CL emit DWARF in PE, please check
http://codereview.appspot.com/2124041/

Thanks.

Wei guangjing

[brainman, 2010-09-02 00:04:48]

> sorry about that.

No worries.

> src/cmd/8l/asm.c:1053: dwarfaddheaders();
> you probably want to disable this one too then.

And why would I do that? I don't understand most of the code here, but as far as
I can see, dwarfaddheaders (it is called dwarfaddelfheaders
 now) is not part of "case 10:" (pe generation) of "switch(HEADTYPE)". As far as
I can gather, it shouldn't affect anything. Or will it?


Alex

[brainman, 2010-09-02 00:06:44]

On 2010/09/01 16:33:04, vcc wrote:
> I make a CL emit DWARF in PE, please check
> http://codereview.appspot.com/2124041/

Sorry, I just want my program to run now. Then we could deal with adding all
that new code.


Alex

[rsc, 2010-09-02 01:11:33]

LGTM

If the current CL is enough to make your binaries run,
then great.

Russ

[brainman, 2010-09-02 01:14:15]

On 2010/09/02 01:11:33, rsc wrote:
> LGTM
> 
> If the current CL is enough to make your binaries run,
> then great.

Should I ignore Luuk's comment, or should I wait for him to reply?

Alex

[rsc, 2010-09-02 01:16:22]

> Should I ignore Luuk's comment, or should I wait for him to reply?

Luuk's asleep.  If it helps you make progress, feel free to
submit what you have and worry about the rest in a future CL.

Russ

[brainman, 2010-09-02 01:19:52]

On 2010/09/02 01:16:22, rsc wrote:
> Luuk's asleep.  If it helps you make progress, feel free to
> submit what you have and worry about the rest in a future CL.

It is one line change. It doesn't bother me one way or the other. I'll wait for
Luuk, I might be missing something here.

Alex

[lvd, 2010-09-02 06:31:40]

LGTM

On 2010/09/02 01:19:52, brainman wrote:
> On 2010/09/02 01:16:22, rsc wrote:
> > Luuk's asleep.  If it helps you make progress, feel free to
> > submit what you have and worry about the rest in a future CL.
> 
> It is one line change. It doesn't bother me one way or the other. I'll wait
for
> Luuk, I might be missing something here.
> 
> Alex

[brainman, 2010-09-02 07:00:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=e785d68bf901 ***

8l: suppress emitting DWARF in Windows PE.

Fixes issue 1064.

R=rsc, lvd, vcc
CC=golang-dev
http://codereview.appspot.com/2104042

Committer: Alex Brainman <alex.brainman@gmail.com>