Issue 210044: code review 210044: time.Ticker: fix bug arising when all tickers are dead.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 210044: code review 210044: time.Ticker: fix bug arising when all tickers are dead. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by r

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

time.Ticker: fix bug arising when all tickers are dead. thanks to yglgogo for analysis. Fixes issue 593.

Patch Set 2 : code review 210044: time.Ticker: fix bug arising when all tickers are dead. #

Total comments: 1

Patch Set 3 : code review 210044: time.Ticker: fix bug arising when all tickers are dead. #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
	M	src/pkg/time/tick.go	View	1 2	2 chunks	+15 lines, -6 lines	0 comments	Download
	M	src/pkg/time/tick_test.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 4 months ago (2010-02-17 05:18:13 UTC) #1

rsc

LGTM http://codereview.appspot.com/210044/diff/6/7 File src/pkg/time/tick.go (right): http://codereview.appspot.com/210044/diff/6/7#newcode42 src/pkg/time/tick.go:42: // If there's no wakeLoop, start one. nice ...

15 years, 4 months ago (2010-02-17 15:19:32 UTC) #2

15 years, 3 months ago (2010-02-17 22:55:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9da37c7ba72b ***

time.Ticker: fix bug arising when all tickers are dead.
thanks to yglgogo for analysis.

Fixes issue 593.

R=rsc
CC=golang-dev
http://codereview.appspot.com/210044

Expand All Messages | Collapse All Messages