Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 2098044: code review 2098044: godoc: moved package directory support code into separa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by gri
Modified:
14 years, 6 months ago
Reviewers:
CC:
r, adg1, golang-dev
Visibility:
Public.

Description

godoc: moved package directory support code into separate file - in prep. for some restructuring to be able to better deal with very large file systems - moved a utility function into index.go - no functionality changes, only code reorg.

Patch Set 1 #

Patch Set 2 : code review 2098044: godoc: moved package directory support code into separa... #

Patch Set 3 : code review 2098044: godoc: moved package directory support code into separa... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -298 lines) Patch
M src/cmd/godoc/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/godoc/dirtrees.go View 1 chunk +301 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 3 chunks +1 line, -298 lines 0 comments Download
M src/cmd/godoc/index.go View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 6 months ago (2010-09-07 23:50:05 UTC) #1
adg1
LGTM On 8 September 2010 09:50, <gri@golang.org> wrote: > Reviewers: r, > > Message: > ...
14 years, 6 months ago (2010-09-08 00:19:01 UTC) #2
gri
14 years, 6 months ago (2010-09-08 00:21:03 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3a8cef6d215a ***

godoc: moved package directory support code into separate file

- in prep. for some restructuring to be able to better deal
  with very large file systems
- moved a utility function into index.go
- no functionality changes, only code reorg.

R=r, adg1
CC=golang-dev
http://codereview.appspot.com/2098044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b