Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(648)

Issue 207104: Matrix propagation loss model

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by Pavel Boyko
Modified:
11 years, 1 month ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Updated after Mathieu's comments (+ bugfix inside) #

Patch Set 3 : Usage example added (needs bug 834 patch) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -0 lines) Patch
A examples/wireless/wifi-hidden-terminal.cc View 1 chunk +133 lines, -0 lines 0 comments Download
M examples/wireless/wscript View 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/propagation-loss-model.h View 1 2 3 chunks +41 lines, -0 lines 0 comments Download
M src/common/propagation-loss-model.cc View 1 2 chunks +76 lines, -0 lines 0 comments Download
M src/common/propagation-loss-model-test-suite.cc View 1 2 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Mathieu Lacage
http://codereview.appspot.com/207104/diff/1/3 File src/common/propagation-loss-model.cc (right): http://codereview.appspot.com/207104/diff/1/3#newcode781 src/common/propagation-loss-model.cc:781: std::map<NodePair, double>::const_iterator i = m_loss.find (std::make_pair (na, nb)); it ...
11 years, 1 month ago (2010-02-16 15:15:14 UTC) #1
Pavel Boyko
Updated http://codereview.appspot.com/207104/diff/1/3 File src/common/propagation-loss-model.cc (right): http://codereview.appspot.com/207104/diff/1/3#newcode781 src/common/propagation-loss-model.cc:781: std::map<NodePair, double>::const_iterator i = m_loss.find (std::make_pair (na, nb)); ...
11 years, 1 month ago (2010-02-16 15:38:54 UTC) #2
Mathieu Lacage
+1 for merging for me. Mathieu -- Mathieu Lacage <mathieu.lacage@gmail.com>
11 years, 1 month ago (2010-02-16 15:50:01 UTC) #3
Nicola Baldo
I think this patch is ok. One minor comment below. Furthermore, it would be good ...
11 years, 1 month ago (2010-02-16 16:16:35 UTC) #4
Pavel Boyko
http://codereview.appspot.com/207104/diff/1/4 File src/common/propagation-loss-model.h (right): http://codereview.appspot.com/207104/diff/1/4#newcode487 src/common/propagation-loss-model.h:487: void SetLoss (Ptr<Node> a, Ptr<Node> b, double loss, bool ...
11 years, 1 month ago (2010-02-16 16:24:44 UTC) #5
Nicola Baldo
On Tue, Feb 16, 2010 at 5:24 PM, <pavel.boyko@gmail.com> wrote: > > I find NS_ASSERT ...
11 years, 1 month ago (2010-02-22 10:56:02 UTC) #6
Pavel Boyko
Hi, Nicola, I have added simple example, please take a look. Unfortunately there seems to ...
11 years, 1 month ago (2010-03-05 12:29:48 UTC) #7
Josh Pelkey
On 2010/03/05 12:29:48, Pavel Boyko wrote: > Hi, Nicola, > > I have added simple ...
11 years, 1 month ago (2010-03-05 16:16:23 UTC) #8
Nicola Baldo
11 years, 1 month ago (2010-03-05 17:57:09 UTC) #9
On 2010/03/05 12:29:48, Pavel Boyko wrote:
>   I have added simple example, please take a look. Unfortunately there seems
to
> be a bug in flow monitor, so please consider applying patch from
> http://www.nsnam.org/bugzilla/show_bug.cgi?id=834 to make the example working.

> 


Cool! I think it is a very interesting example!
+1 to merge after your patch for bug 834 has been committed.

Nicola
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b