Code looks fine - just a few small requested tweaks. http://codereview.appspot.com/207091/diff/1/8 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java (right): http://codereview.appspot.com/207091/diff/1/8#newcode92 ...
15 years, 11 months ago
(2010-02-16 19:20:00 UTC)
#2
Code looks fine - just a few small requested tweaks.
http://codereview.appspot.com/207091/diff/1/8
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java
(right):
http://codereview.appspot.com/207091/diff/1/8#newcode92
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java:92:
Log.info("Bad TTL value '" + ttlStr + "' was ignored");
Looks like IDE creep here -- could you switch this to the typical style (Logger
log = Logger.getLogger(clazz);)?
http://codereview.appspot.com/207091/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java
(right):
http://codereview.appspot.com/207091/diff/1/2#newcode209
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java:209:
// a content type like text/html which unfortunately happens all too often
odd, chunk mismatch error in this file. Try syncing and re-sending the patch.
http://codereview.appspot.com/207091/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(right):
http://codereview.appspot.com/207091/diff/1/3#newcode180
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:180:
// Use a 'Vary' style check on the response
same
Definite improvement, thanks Ziv. We might consider returning 400s in these cases as well, but ...
15 years, 11 months ago
(2010-02-16 23:28:16 UTC)
#4
Definite improvement, thanks Ziv. We might consider returning 400s in these
cases as well, but I've committed this patch in the meantime since it's not
clear that malformed refresh values should really issue an error (or
alternately, that they should yield refresh-friendly behavior).
Issue 207091: Handle bad TTL in requests
Created 15 years, 11 months ago by zhoresh
Modified 15 years, 11 months ago
Reviewers: shindig.remailer_gmail.com, johnfargo
Base URL: http://svn.apache.org/repos/asf/shindig/trunk/
Comments: 3