Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 207091: Handle bad TTL in requests

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by zhoresh
Modified:
16 years, 1 month ago
Reviewers:
johnfargo, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Handle NumberFormatException when converting request TTL to int.

Patch Set 1 #

Total comments: 3

Patch Set 2 : I fixed the log, and remove unneeded files #

Messages

Total messages: 4
zhoresh
16 years, 1 month ago (2010-02-13 02:49:30 UTC) #1
johnfargo
Code looks fine - just a few small requested tweaks. http://codereview.appspot.com/207091/diff/1/8 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java (right): http://codereview.appspot.com/207091/diff/1/8#newcode92 ...
16 years, 1 month ago (2010-02-16 19:20:00 UTC) #2
zhoresh
I fixed the log, and remove unneeded files
16 years, 1 month ago (2010-02-16 21:11:21 UTC) #3
johnfargo
16 years, 1 month ago (2010-02-16 23:28:16 UTC) #4
Definite improvement, thanks Ziv. We might consider returning 400s in these
cases as well, but I've committed this patch in the meantime since it's not
clear that malformed refresh values should really issue an error (or
alternately, that they should yield refresh-friendly behavior).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b